Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up disposables in early-return path of ClangdContext.create() #743

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Clean up disposables in early-return path of ClangdContext.create() #743

merged 1 commit into from
Dec 4, 2024
+5 −6

Conversation

HighCommander4
Copy link
Contributor

@HighCommander4 HighCommander4 commented Dec 4, 2024 •
edited
Loading

Other minor cleanup:

  • do not await config.get(), it's not async
  • move initialization of clangdArguments into create()

Fixes #739

@HighCommander4
Clean up disposables in early-return path of ClangdContext.create()
2e19eea 
Other minor cleanup:
  - do not await config.get(), it's not async
  - move initialization of clangdArguments into create()
@HighCommander4 HighCommander4 requested a review from hokein December 4, 2024 06:12
@HighCommander4 HighCommander4 mentioned this pull request Dec 4, 2024
Closed
@HighCommander4 HighCommander4 merged commit ea33181 into clangd:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokein hokein hokein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression with clangd.restart command
2 participants
@HighCommander4 @hokein